Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: add ability to pass timeout to ack #2042

Merged
merged 3 commits into from
Mar 27, 2017
Merged

pubsub: add ability to pass timeout to ack #2042

merged 3 commits into from
Mar 27, 2017

Conversation

jcking
Copy link

@jcking jcking commented Mar 2, 2017

See #1979.

Something like this "should" work assuming the protoOpts are passed as is to gax, granted I haven't tested it yet. This adds an options argument to Subscription.prototype.ack that forwards options.timeout to gax. It preserves existing behavior and replicates the style of arguments orders that is consistent with the rest of the library.

Feel free to nit pick as this was quick and dirty while investigating another issue, I was in the neighborhood.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2017
@jcking
Copy link
Author

jcking commented Mar 2, 2017

This is related to #1974 as well. Additionally I am not sure if we want to propagate the timeout option given at the creation of the Subscription?

@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Mar 3, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 27, 2017
@stephenplusplus
Copy link
Contributor

Sorry for the long delay on this one. I've added tests -- let's see what CI thinks!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.912% when pulling d0accde on jcking:pubsub-ack-timeout into 688ac58 on GoogleCloudPlatform:master.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.0e-05%) to 99.924% when pulling ed4f719 on jcking:pubsub-ack-timeout into 688ac58 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit bc0503e into googleapis:master Mar 27, 2017
@stephenplusplus
Copy link
Contributor

Thanks @jcking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants