Cleanup error handling/docs in TaskList #147

ajkannan · 2016-04-02T01:21:51Z

coveralls · 2016-04-02T01:40:27Z

Coverage increased (+0.01%) to 21.17% when pulling 1ec11ab on cleanup-tasklist into c4439f6 on master.

aozarov · 2016-04-02T02:53:59Z

datastore/src/main/java/com/google/datastore/snippets/TaskList.java

@@ -51,7 +50,8 @@
   * Adds a task entity to the Datastore.
   *
   * @param description The task description
-   * @return The {@link Key} of the entity.
+   * @return The {@link Key} of the entity
+   * @throws DatastoreException if the Datastore put fails


technically it could also throw DatastoreException if Id allocation failed.

aozarov · 2016-04-02T03:03:22Z

Looks good. Few nits. Feel free to merge without them.

coveralls · 2016-04-02T16:21:03Z

Coverage increased (+0.01%) to 21.17% when pulling 41dbfd9 on cleanup-tasklist into c4439f6 on master.

ajkannan · 2016-04-02T18:38:34Z

Fixed comments

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.truth:truth](com/google/truth/truth) | minor | `1.0.1` -> `1.1` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-mediatranslation).

…147) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `11.0.0` -> `12.0.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).

…5.1 (#147) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.5.0` -> `2.5.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.5.1/compatibility-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.5.1/confidence-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.5.1`](https://togithub.com/googleapis/java-bigquery/blob/master/CHANGELOG.md#251-httpswwwgithubcomgoogleapisjava-bigquerycomparev250v251-2021-12-03) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.5.0...v2.5.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).

…147) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `4.4.1` -> `5.1.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-dialogflow).

…147) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `4.4.1` -> `5.0.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-asset).

Cleanup error handling/docs in TaskList

1ec11ab

ajkannan force-pushed the cleanup-tasklist branch from 0382d1b to 1ec11ab Compare April 2, 2016 01:24

aozarov reviewed Apr 2, 2016
View reviewed changes

Correct throws statements

41dbfd9

ajkannan merged commit e4ce96d into master Apr 2, 2016

ajkannan deleted the cleanup-tasklist branch April 2, 2016 18:38

anguillanneuf mentioned this pull request Oct 24, 2022

feat: migrate code from googleapis/java-mediatranslation #7356

Merged

9 tasks

bourgeoisor mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-notification #7406

Closed

9 tasks

Shabirmean mentioned this pull request Nov 11, 2022

samples: migrate code from googleapis/java-contact-center-insights #7411

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-dialogflow #7420

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup error handling/docs in TaskList #147

Cleanup error handling/docs in TaskList #147

ajkannan commented Apr 2, 2016

coveralls commented Apr 2, 2016

aozarov Apr 2, 2016

aozarov commented Apr 2, 2016

coveralls commented Apr 2, 2016

ajkannan commented Apr 2, 2016

Cleanup error handling/docs in TaskList #147

Cleanup error handling/docs in TaskList #147

Conversation

ajkannan commented Apr 2, 2016

coveralls commented Apr 2, 2016

aozarov Apr 2, 2016

Choose a reason for hiding this comment

aozarov commented Apr 2, 2016

coveralls commented Apr 2, 2016

ajkannan commented Apr 2, 2016