-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mockgcp: vertexai support #1254
mockgcp: vertexai support #1254
Conversation
justinsb
commented
Feb 16, 2024
- tests: introduce test for VertexAITensorboard
- autogen: Generate proto files for vertexai
- mockgcp: support VertexAIDashboard
- tests: add golden http output for vertextensorboard
We're using v1beta1 for now.
/assign @jingyih I thought this might help to get the ball rolling! |
2085e30
to
87393b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I've only done a quick review. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4829fc3
into
GoogleCloudPlatform:master