Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockgcp: vertexai support #1254

Merged
merged 4 commits into from
Feb 23, 2024
Merged

mockgcp: vertexai support #1254

merged 4 commits into from
Feb 23, 2024

Conversation

justinsb
Copy link
Collaborator

  • tests: introduce test for VertexAITensorboard
  • autogen: Generate proto files for vertexai
  • mockgcp: support VertexAIDashboard
  • tests: add golden http output for vertextensorboard

@justinsb justinsb changed the title vertexai integration mockgcp: vertexai support Feb 16, 2024
@justinsb
Copy link
Collaborator Author

/assign @jingyih

I thought this might help to get the ball rolling!

jingyih
jingyih reviewed Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I've only done a quick review. Looks good to me.

@google-oss-prow google-oss-prow bot added the lgtm label Feb 19, 2024
jingyih
jingyih reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4829fc3 into GoogleCloudPlatform:master Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih left review comments

Assignees

@jingyih jingyih

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinsb @jingyih