Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use caching for go task in lint github action #1291

Conversation

justinsb
Copy link
Collaborator

This seems to cause double caching.

golangci/golangci-lint-action#135

@justinsb justinsb force-pushed the but_who_enforces_quality_on_the_linter branch from a774316 to 293ab2d Compare February 27, 2024 15:17
@justinsb justinsb changed the title chore: don't install go in lint github action chore: don't use caching for go task in lint github action Feb 27, 2024
@justinsb justinsb force-pushed the but_who_enforces_quality_on_the_linter branch from 293ab2d to 4c7a68f Compare February 27, 2024 15:23
@justinsb
Copy link
Collaborator Author

/assign @acpana

@acpana
Copy link
Collaborator

acpana commented Feb 27, 2024

thanks for patching this 💯

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 27, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 07df53e into GoogleCloudPlatform:master Feb 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants