feat: Outbound public IP support for AlloyDB instances #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nancynh
force-pushed
the
outbound-public-ip
branch
from
59466ff
to
c801f49
Compare
nancynh
changed the title
nancynh
force-pushed
the
outbound-public-ip
branch
from
c801f49
to
5a590d3
Compare
nancynh
force-pushed
the
outbound-public-ip
branch
2 times, most recently
from
5b967c7
to
eae09ee
Compare
… IP field from TF
nancynh
force-pushed
the
outbound-public-ip
branch
from
a084cf8
to
ffb0a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Adds KCC support for AlloyDB instances to have an outbound public IP address. Specifically adds the field
enableOutboundPublicIpto the already existingnetworkConfig. This is for an upcoming feature outbound public IP feature.Fixes b/361373492 and b/352047661
Tests you have done
Ran the e2e tests (output) and saw that it correctly created the instance with outbound public ip enabled and then disabled it
make ready-prto ensure this PR is ready for review.