feat: Migrate compute target TCP proxy(global) to direct controller #3047
Conversation
gemmahou
force-pushed
the
direct-controller-tcp
branch
2 times, most recently
from
83e27b3
to
6afd43c
Compare
gemmahou
force-pushed
the
direct-controller-tcp
branch
2 times, most recently
from
ffa6f3a
to
19487b8
Compare
gemmahou
force-pushed
the
direct-controller-tcp
branch
4 times, most recently
from
b29cc10
to
3acffb1
Compare
gemmahou
force-pushed
the
direct-controller-tcp
branch
from
3acffb1
to
20a4c85
Compare
gemmahou
force-pushed
the
direct-controller-tcp
branch
from
20a4c85
to
15f87db
Compare
| } | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Looks like the real GCP using the TF-based controller. Could you also upload the one using direct controller? (please do that in a new git-commit)
There was a problem hiding this comment.
This log is from ComputeHealthCheck so it's still using TF controller.
There was a problem hiding this comment.
suggest to start developing a shared functionality for compute resource. It looks many compute resource would need this global/regional handling.
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| func ResolveComputeBackendService(ctx context.Context, reader client.Reader, src client.Object, ref *refs.ComputeBackendServiceRef) (*refs.ComputeBackendServiceRef, error) { |
There was a problem hiding this comment.
suggest moving this to API so it can be shared by other services.
|
/lgtm One comment about code refactoring. Otherwise looks good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 3954a2d
into
GoogleCloudPlatform:master
Change description
Prerequisite for b/246759060
Migrate global compute target TCP proxy to direct controller. Will support regional in a followup PR.
Tests you have done
make ready-prto ensure this PR is ready for review.