Update mockalloydb and the test golden files #3190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maqiuyujoyce
commented
Nov 16, 2024
|
|
||
| --- | ||
|
|
||
| GET https://compute.googleapis.com/compute/v1/projects/${projectId}/global/networks/${networkID}?alt=json |
There was a problem hiding this comment.
@gemmahou the GET events for compute address and compute network somehow got deleted when it is running against mock. Wondered if you happen to have any ideas about it.
maqiuyujoyce
force-pushed
the
202411-alloydb-mockgcp
branch
from
d6bc977
to
7f0ee97
Compare
…stance test cases
maqiuyujoyce
force-pushed
the
202411-alloydb-mockgcp
branch
from
7f0ee97
to
7e18a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.