set max bigtable instance cluster to 4 (#2121)

Merged PR #2121.
GoogleCloudPlatform · Aug 5, 2019 · 20dc552 · 20dc552
1 parent bb4c89a
commit 20dc552
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 4 deletions.
diff --git a/build/terraform b/build/terraform
diff --git a/build/terraform-beta b/build/terraform-beta
diff --git a/third_party/terraform/resources/resource_bigtable_instance.go b/third_party/terraform/resources/resource_bigtable_instance.go
@@ -28,7 +28,7 @@ func resourceBigtableInstance() *schema.Resource {
 				Type:     schema.TypeSet,
 				Required: true,
 				ForceNew: true,
-				MaxItems: 2,
+				MaxItems: 4,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"cluster_id": {

diff --git a/third_party/terraform/tests/resource_bigtable_instance_test.go b/third_party/terraform/tests/resource_bigtable_instance_test.go
@@ -3,6 +3,7 @@ package google
 import (
 	"context"
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform/helper/acctest"
@@ -48,6 +49,10 @@ func TestAccBigtableInstance_cluster(t *testing.T) {
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckBigtableInstanceDestroy,
 		Steps: []resource.TestStep{
+			{
+				Config:      testAccBigtableInstance_clusterMax(instanceName),
+				ExpectError: regexp.MustCompile("config is invalid: Too many cluster blocks: No more than 4 \"cluster\" blocks are allowed"),
+			},
 			{
 				Config: testAccBigtableInstance_cluster(instanceName),
 				Check: resource.ComposeTestCheckFunc(
@@ -152,18 +157,68 @@ resource "google_bigtable_instance" "instance" {
 	name = "%s"
 	cluster {
 		cluster_id   = "%s-a"
+		zone         = "us-central1-a"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
+	cluster {
+		cluster_id   = "%s-b"
 		zone         = "us-central1-b"
 		num_nodes    = 3
 		storage_type = "HDD"
 	}
+	cluster {
+		cluster_id   = "%s-c"
+		zone         = "us-central1-c"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
+	cluster {
+		cluster_id   = "%s-d"
+		zone         = "us-central1-f"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
+}
+`, instanceName, instanceName, instanceName, instanceName, instanceName)
+}
+
+func testAccBigtableInstance_clusterMax(instanceName string) string {
+	return fmt.Sprintf(`
+resource "google_bigtable_instance" "instance" {
+	name = "%s"
+	cluster {
+		cluster_id   = "%s-a"
+		zone         = "us-central1-a"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
 	cluster {
 		cluster_id   = "%s-b"
+		zone         = "us-central1-b"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
+	cluster {
+		cluster_id   = "%s-c"
 		zone         = "us-central1-c"
 		num_nodes    = 3
 		storage_type = "HDD"
 	}
+	cluster {
+		cluster_id   = "%s-d"
+		zone         = "us-central1-f"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
+	cluster {
+		cluster_id   = "%s-e"
+		zone         = "us-east1-a"
+		num_nodes    = 3
+		storage_type = "HDD"
+	}
 }
-`, instanceName, instanceName, instanceName)
+`, instanceName, instanceName, instanceName, instanceName, instanceName, instanceName)
 }
 
 func testAccBigtableInstance_development(instanceName string) string {