cloudbuild build trigger's trigger template should be required in 3.0.0.

GoogleCloudPlatform · Sep 24, 2019 · 5104c55 · 5104c55
1 parent 7ab5aaf
commit 5104c55
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/products/cloudbuild/api.yaml b/products/cloudbuild/api.yaml
@@ -101,6 +101,7 @@ objects:
           Branch and tag names in trigger templates are interpreted as regular
           expressions. Any branch or tag change that matches that regular
           expression will trigger a build.
+        required: true
         properties:
           - !ruby/object:Api::Type::String
             name: 'projectId'

diff --git a/products/cloudbuild/terraform.yaml b/products/cloudbuild/terraform.yaml
@@ -28,9 +28,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         name: 'trigger_id'
       build.steps: !ruby/object:Overrides::Terraform::PropertyOverride
         name: 'step'
-      triggerTemplate: !ruby/object:Overrides::Terraform::PropertyOverride
-        description: |
-          {{description}}This field is required, and will be validated as such in 3.0.0.
       triggerTemplate.projectId: !ruby/object:Overrides::Terraform::PropertyOverride
         default_from_api: true
     custom_code: !ruby/object:Provider::Terraform::CustomCode