Change rowsLimit to integer and add tests covering rowsLimit, rowsLim…

…itPercent, and sampleMethod

mmv1/products/dlp/api.yaml

@@ -288,7 +288,7 @@ objects:
                         required: true
                         description: |
                           The name of the table.
-                  - !ruby/object:Api::Type::String
+                  - !ruby/object:Api::Type::Integer
                     name: 'rowsLimit'
                     description: |
                       Max number of rows to scan. If the table has more rows than this value, the rest of the rows are omitted. 

mmv1/products/dlp/terraform.yaml

@@ -49,6 +49,20 @@ overrides: !ruby/object:Overrides::ResourceOverrides
           trigger: "trigger"
         test_env_vars:
           project: :PROJECT_NAME
+      - !ruby/object:Provider::Terraform::Examples
+        name: "dlp_job_trigger_bigquery_row_limit"
+        primary_resource_id: "bigquery_row_limit"
+        vars:
+          trigger: "trigger"
+        test_env_vars:
+          project: :PROJECT_NAME
+      - !ruby/object:Provider::Terraform::Examples
+        name: "dlp_job_trigger_bigquery_row_limit_percentage"
+        primary_resource_id: "bigquery_row_limit_percentage"
+        vars:
+          trigger: "trigger"
+        test_env_vars:
+          project: :PROJECT_NAME
     custom_code: !ruby/object:Provider::Terraform::CustomCode
       encoder: templates/terraform/encoders/wrap_object.go.erb
       custom_import: templates/terraform/custom_import/dlp_import.go.erb

mmv1/templates/terraform/examples/dlp_job_trigger_basic.tf.erb

@@ -15,8 +15,8 @@ resource "google_data_loss_prevention_job_trigger" "<%= ctx[:primary_resource_id
 			save_findings {
 				output_config {
 					table {
-						project_id = "asdf"
-						dataset_id = "asdf"
+						project_id = "project"
+						dataset_id = "dataset"
 					}
 				}
 			}

mmv1/templates/terraform/examples/dlp_job_trigger_bigquery_row_limit.tf.erb

@@ -0,0 +1,37 @@
+resource "google_data_loss_prevention_job_trigger" "<%= ctx[:primary_resource_id] %>" {
+	parent = "projects/<%= ctx[:test_env_vars]['project'] %>"
+	description = "Description"
+	display_name = "Displayname"
+
+	triggers {
+		schedule {
+			recurrence_period_duration = "86400s"
+		}
+	}
+
+	inspect_job {
+		inspect_template_name = "fake"
+		actions {
+			save_findings {
+				output_config {
+					table {
+						project_id = "project"
+						dataset_id = "dataset"
+					}
+				}
+			}
+		}
+		storage_config {
+			big_query_options {
+				table_reference {
+				    project_id = "project"
+				    dataset_id = "dataset"
+				    table_id = "table_to_scan"
+				}
+
+				rowsLimit = 1000
+				sampleMethod = "RANDOM_START"
+			}
+		}
+	}
+}

mmv1/templates/terraform/examples/dlp_job_trigger_bigquery_row_limit_percentage.tf.erb

@@ -0,0 +1,37 @@
+resource "google_data_loss_prevention_job_trigger" "<%= ctx[:primary_resource_id] %>" {
+	parent = "projects/<%= ctx[:test_env_vars]['project'] %>"
+	description = "Description"
+	display_name = "Displayname"
+
+	triggers {
+		schedule {
+			recurrence_period_duration = "86400s"
+		}
+	}
+
+	inspect_job {
+		inspect_template_name = "fake"
+		actions {
+			save_findings {
+				output_config {
+					table {
+						project_id = "project"
+						dataset_id = "dataset"
+					}
+				}
+			}
+		}
+		storage_config {
+			big_query_options {
+				table_reference {
+				    project_id = "project"
+				    dataset_id = "dataset"
+				    table_id = "table_to_scan"
+				}
+
+				rowsLimitPercent = 50
+				sampleMethod = "RANDOM_START"
+			}
+		}
+	}
+}