Remove string concatenation in spanner DB update (#4294)

GoogleCloudPlatform · Dec 8, 2020 · f407f63 · f407f63
1 parent 257896e
commit f407f63
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/templates/terraform/update_encoder/spanner_database.go.erb b/templates/terraform/update_encoder/spanner_database.go.erb
@@ -22,7 +22,7 @@ for i := len(oldDdls); i < len(newDdls); i++ {
     updateDdls = append(updateDdls, newDdls[i].(string))
 }
 
-obj["statements"] = strings.Join(updateDdls, ",")
+obj["statements"] = updateDdls
 delete(obj, "name")
 delete(obj, "instance")
 delete(obj, "extraStatements")

diff --git a/third_party/terraform/tests/resource_spanner_database_test.go b/third_party/terraform/tests/resource_spanner_database_test.go
@@ -109,6 +109,7 @@ resource "google_spanner_database" "basic" {
 	"CREATE TABLE t1 (t1 INT64 NOT NULL,) PRIMARY KEY(t1)",
 	"CREATE TABLE t2 (t2 INT64 NOT NULL,) PRIMARY KEY(t2)",
 	"CREATE TABLE t3 (t3 INT64 NOT NULL,) PRIMARY KEY(t3)",
+	"CREATE TABLE t4 (t4 INT64 NOT NULL,) PRIMARY KEY(t4)",
   ]
   deletion_protection = false
 }