Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate comment diff processor build failure #10164

Merged
merged 22 commits into from
Mar 13, 2024
Merged

Fix generate comment diff processor build failure #10164

merged 22 commits into from
Mar 13, 2024

Commits on Mar 11, 2024

  1. Refactored generate_comment to continue in the face of errors 

    Also switched to go template for comment formatting
    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c32bac6 View commit details
    Browse the repository at this point in the history

  2. Moved to structured data for diffs 

    Also added error formatting into comment
    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3c361a6 View commit details
    Browse the repository at this point in the history

  3. Added basic tests for comment formatting

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7bb79f1 View commit details
    Browse the repository at this point in the history

  4. Skipped missing tests and breaking changes if repo failed to clone

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    46f1da8 View commit details
    Browse the repository at this point in the history

  5. Force generation

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    596d1eb View commit details
    Browse the repository at this point in the history

  6. Breaking change

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    fb04ad4 View commit details
    Browse the repository at this point in the history

  7. Fixed error display in diff comment

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    856bd74 View commit details
    Browse the repository at this point in the history

  8. Marked diff-processor targets as not being real files

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cfb5ab5 View commit details
    Browse the repository at this point in the history

  9. Added PATH to diffProcessorEnv

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3a2960e View commit details
    Browse the repository at this point in the history

  10. Fixed formatting for error sections

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    53cc86d View commit details
    Browse the repository at this point in the history

  11. Cleaned up passthrough env var usage

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    210d246 View commit details
    Browse the repository at this point in the history

  12. Made exec.sh exit 1 if there are any errors running the magician

    @melinath
    melinath committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0ca59a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Don't error on initial build of the magician binary

    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    168b050 View commit details
    Browse the repository at this point in the history

  2. Added missing env var for diff processor build

    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c7d7082 View commit details
    Browse the repository at this point in the history

  3. Force generation of tf-oics

    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fcb65f1 View commit details
    Browse the repository at this point in the history

  4. Revert "Force generation of tf-oics" 

    This reverts commit fcb65f1.
    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9838115 View commit details
    Browse the repository at this point in the history

  5. Revert "Force generation" 

    This reverts commit 596d1eb.
    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    942a2dd View commit details
    Browse the repository at this point in the history

  6. Revert "Breaking change" 

    This reverts commit fb04ad4.
    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c5e1118 View commit details
    Browse the repository at this point in the history

  7. Force missing test run

    @melinath
    melinath committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    90e664a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. force missing tests to run - take 2

    @melinath
    melinath committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    34f7d16 View commit details
    Browse the repository at this point in the history

  2. Revert "force missing tests to run - take 2" 

    This reverts commit 34f7d16.
    @melinath
    melinath committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ba4e8de View commit details
    Browse the repository at this point in the history

  3. Revert "Force missing test run" 

    This reverts commit 90e664a.
    @melinath
    melinath committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a56056e View commit details
    Browse the repository at this point in the history