Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect service labels for PRs based on changed files #10248

Merged
merged 15 commits into from
Mar 27, 2024
Merged

Detect service labels for PRs based on changed files #10248

merged 15 commits into from
Mar 27, 2024

Conversation

melinath
Copy link
Member

b/330551693

Some schema changes can't be detected by file changes; some file changes don't show up as schema changes. By doing both we get more accurate coverage of impacted services.

Release Note Template for Downstream PRs (will be copied)

@melinath melinath requested review from a team and roaks3 and removed request for a team March 21, 2024 16:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@melinath
Copy link
Member Author

Looks like this isn't quite working

@melinath melinath marked this pull request as draft March 21, 2024 17:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@melinath melinath marked this pull request as ready for review March 21, 2024 18:51
@melinath melinath requested review from roaks3 and removed request for roaks3 March 21, 2024 18:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

melinath added a commit to melinath/magic-modules that referenced this pull request Mar 21, 2024
@melinath
Corrected names of iam_workload resource and data source files
7ba9539 
beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
@melinath melinath mentioned this pull request Mar 21, 2024
Merged
melinath added a commit that referenced this pull request Mar 22, 2024
@melinath
Corrected names of iam_workload resource and data source files (#10253)
ae121dd 
beta is not part of the resource name. This is important for #10248
This was referenced Mar 22, 2024
Merged
Merged
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Mar 22, 2024
@modular-magician
Corrected names of iam_workload resource and data source files (#10253)
4ed4bcc 
beta is not part of the resource name. This is important for GoogleCloudPlatform/magic-modules#10248

[upstream:ae121ddbe32876773ff3841419eddbb7b21ea9b5]

Signed-off-by: Modular Magician <[email protected]>
@melinath melinath requested a review from roaks3 March 27, 2024 16:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath merged commit 90972e3 into GoogleCloudPlatform:main Mar 27, 2024
11 checks passed
@melinath melinath deleted the b-330551693 branch March 27, 2024 20:04
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 27, 2024
@melinath @BBBmau
Corrected names of iam_workload resource and data source files (Googl…
4270443 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 27, 2024
@melinath @BBBmau
Detect service labels for PRs based on changed files (GoogleCloudPlat…
8c6ff36 
…form#10248)
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
@melinath @pjotrekk
Corrected names of iam_workload resource and data source files (Googl…
b6afadd 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
@melinath @pjotrekk
Detect service labels for PRs based on changed files (GoogleCloudPlat…
8c8a0c9 
…form#10248)
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
@melinath @cmfeng
Corrected names of iam_workload resource and data source files (Googl…
10856c9 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
@melinath @cmfeng
Detect service labels for PRs based on changed files (GoogleCloudPlat…
a690428 
…form#10248)
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
@melinath @hao-nan-li
Corrected names of iam_workload resource and data source files (Googl…
994965d 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
@melinath @hao-nan-li
Detect service labels for PRs based on changed files (GoogleCloudPlat…
d21c24d 
…form#10248)
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
@melinath @balanaguharsha
Corrected names of iam_workload resource and data source files (Googl…
78b7e88 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
@melinath @balanaguharsha
Detect service labels for PRs based on changed files (GoogleCloudPlat…
2cc3627 
…form#10248)
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@melinath @balanaguharsha
Corrected names of iam_workload resource and data source files (Googl…
8c71642 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@melinath @balanaguharsha
Detect service labels for PRs based on changed files (GoogleCloudPlat…
59e0f88 
…form#10248)
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@melinath @balanaguharsha
Corrected names of iam_workload resource and data source files (Googl…
302af03 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@melinath @balanaguharsha
Detect service labels for PRs based on changed files (GoogleCloudPlat…
dfe2c01 
…form#10248)
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
@melinath @pawelJas
Corrected names of iam_workload resource and data source files (Googl…
751387f 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
@melinath @pawelJas
Detect service labels for PRs based on changed files (GoogleCloudPlat…
7cbd65e 
…form#10248)
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@melinath @pengq-google
Corrected names of iam_workload resource and data source files (Googl…
6c83150 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@melinath @pengq-google
Detect service labels for PRs based on changed files (GoogleCloudPlat…
1ace7ef 
…form#10248)
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
@melinath @Cheriit
Corrected names of iam_workload resource and data source files (Googl…
4ffaddb 
…eCloudPlatform#10253)

beta is not part of the resource name. This is important for GoogleCloudPlatform#10248
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
@melinath @Cheriit
Detect service labels for PRs based on changed files (GoogleCloudPlat…
2b07cf1 
…form#10248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 roaks3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melinath @modular-magician @roaks3