Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertex_ai_model_resource :copy #10628

Closed

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented May 8, 2024

As the vertex_ai_models work continues to get larger, rather than treat it as one massive PR the goal is to treat each section of what comes with creating an ai model in google cloud. One of them being :copy and the other being :upload which is worked on more in this PR #9767 which will take much more time due to the different variables that come with creating a model (Tabular Models, image recognition models, speech models, etc.)

With :copy being completed with the ability to create and delete copied models within a project, what's left is creating tests.

Simplest tfconfig to copy an already existing model in your project

resource "google_vertex_ai_models" "copy" {
	project = "hc-17ccbe3c280c434a87e301c7c95"
	source_model = "projects/hc-17ccbe3c280c434a87e301c7c95/locations/us-central1/models/5460298988349554688"
	region = "us-central1"
}

Release Note Template for Downstream PRs (will be copied)

vertex_ai: added `vertex_ai_model_resource`

@BBBmau BBBmau force-pushed the add-vertex-ai-model-COPY branch 2 times, most recently from 81902a3 to 53b1405 Compare May 8, 2024 05:03
@BBBmau BBBmau marked this pull request as draft May 8, 2024 05:05
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@rileykarson

This comment was marked as outdated.

@rileykarson rileykarson closed this Sep 6, 2024
@BBBmau

This comment was marked as outdated.

@BBBmau BBBmau reopened this Oct 8, 2024
Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few errors impacting the build - if you build the provider locally from this PR the error messages should tell you all you need to know. I've left some suggestions that help with some of the issues

mmv1/products/vertexai/Models.yaml Outdated Show resolved Hide resolved
mmv1/products/vertexai/Models.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3046 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3046 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 799 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  model_id            = # value needed
  parent_model        = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3046 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3046 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 799 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  model_id            = # value needed
  parent_model        = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3064 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3064 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 807 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  model_id            = # value needed
  parent_model        = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3064 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3064 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 807 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  model_id            = # value needed
  parent_model        = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3032 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 797 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_models (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_models" "primary" {
  artifact_uri = # value needed
  container_spec {
    args               = # value needed
    command            = # value needed
    deployment_timeout = # value needed
    env {
      name  = # value needed
      value = # value needed
    }
    grpc_ports {
      container_port = # value needed
    }
    health_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
    health_route = # value needed
    image_uri    = # value needed
    ports {
      container_port = # value needed
    }
    predict_route         = # value needed
    shared_memory_size_mb = # value needed
    startup_probe {
      exec {
        command = # value needed
      }
      period_seconds  = # value needed
      timeout_seconds = # value needed
    }
  }
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  metadata {
    config {
      algorithm_config {
        tree_ah_config {
          leaf_node_embedding_count    = # value needed
          leaf_nodes_to_search_percent = # value needed
        }
      }
      approximate_neighbors_count = # value needed
      dimensions                  = # value needed
      distance_measure_type       = # value needed
      feature_norm_type           = # value needed
      shard_size                  = # value needed
    }
    contents_delta_uri    = # value needed
    is_complete_overwrite = # value needed
  }
  metadata_schema_uri = # value needed
  model               = # value needed
  pipeline_job        = # value needed
  predict_schemata {
    instance_schema_uri   = # value needed
    parameters_schema_uri = # value needed
    prediction_schema_uri = # value needed
  }
  supported_export_formats {
    exportable_content = # value needed
  }
  version_aliases = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIModels_vertexAiModelSourceBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccVertexAIModels_vertexAiModelSourceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau
Copy link
Collaborator Author

BBBmau commented Oct 21, 2024

Closing in favor of #12074

@BBBmau BBBmau closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants