Add standby_policy along with suspended / stopped target size.

[chayankumar999]

This added IGM.StandbyPolicy and (R)IGM.StandbyPolicy functionalities in Beta. Also added TargetSuspendedSize and TargetStoppedSize functionalities for both IGM and (R)IGM.

compute: added `standby_policy`, `target_suspended_size` and  `target_stopped_size`  fields to `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager ` resources (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[chayankumar999]

Hello @askubis, please review the PR.

[zli82016]

Feel free to let me know when it is ready for review.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+))
google-beta provider: Diff ( 6 files changed, 464 insertions(+))

[modular-magician]

Tests analytics

Total tests: 935
Passed tests: 803
Skipped tests: 72
Affected tests: 60

Click here to see the affected service packages

• compute

Action taken

Found 60 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_stoppedSuspendedTargetSize|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccInstanceGroupManager_stoppedSuspendedTargetSize[Debug log]
TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAutoscaler_autoscalerBasicExample[Error message] [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]
TestAccComputeAutoscaler_multicondition[Error message] [Debug log]
TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControlFixed[Error message] [Debug log]
TestAccComputeAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeAutoscaler_update[Error message] [Debug log]
TestAccComputeBackendService_withBackend[Error message] [Debug log]
TestAccComputeBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeBackendService_withBackendAndMaxUtilization[Error message] [Debug log]
TestAccComputeBackendService_withMaxConnections[Error message] [Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]
TestAccComputePerInstanceConfig_statefulIps[Error message] [Debug log]
TestAccComputePerInstanceConfig_update[Error message] [Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeRegionAutoscaler_update[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Error message] [Debug log]
TestAccComputeRegionPerInstanceConfig_update[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_fromIGM[Error message] [Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccInstanceGroupManager_basic[Error message] [Debug log]
TestAccInstanceGroupManager_resourceManagerTags[Error message] [Debug log]
TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log]
TestAccInstanceGroupManager_stateful[Error message] [Debug log]
TestAccInstanceGroupManager_targetSizeZero[Error message] [Debug log]
TestAccInstanceGroupManager_update[Error message] [Debug log]
TestAccInstanceGroupManager_versions[Error message] [Debug log]
TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log]
TestAccRegionInstanceGroupManager_APISideListRecordering[Error message] [Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccRegionInstanceGroupManager_basic[Error message] [Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Error message] [Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Error message] [Debug log]
TestAccRegionInstanceGroupManager_update[Error message] [Debug log]
TestAccRegionInstanceGroupManager_versions[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[chayankumar999]

Feel free to let me know when it is ready for review.

hey, I think it's now ready for review. Can you start reviewing this PR?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 73 insertions(+))
google-beta provider: Diff ( 6 files changed, 504 insertions(+))

[chayankumar999]

Can you also modify the release notes following the doc ? Thanks.

If there is a related Github issue, feel free to add it to the description section of this PR.

I updated the description of the PR. Please check. Thanks!

[chayankumar999]

The failed tests are unrelated.

What should I have to do for that? I am not sure about it.

[modular-magician]

Tests analytics

Total tests: 939
Passed tests: 840
Skipped tests: 72
Affected tests: 27

Click here to see the affected service packages

• compute

Action taken

Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeTargetPool_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_update

Get to know how VCR tests work

[zli82016]

The failed tests are unrelated.

What should I have to do for that? I am not sure about it.

No worries, I will handle it.

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeAutoscaler_autoscalerBasicExample[Debug log]
TestAccComputeAutoscaler_scaleInControl[Debug log]
TestAccComputeAutoscaler_scaleInControlFixed[Debug log]
TestAccComputeAutoscaler_scalingSchedule[Debug log]
TestAccComputeAutoscaler_update[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]
TestAccComputeAutoscaler_multicondition[Error message] [Debug log]
TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeRegionAutoscaler_update[Error message] [Debug log]
TestAccComputeTargetPool_basic[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccInstanceGroupManager_basic[Error message] [Debug log]
TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log]
TestAccInstanceGroupManager_stateful[Error message] [Debug log]
TestAccInstanceGroupManager_update[Error message] [Debug log]
TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccRegionInstanceGroupManager_basic[Error message] [Debug log]
TestAccRegionInstanceGroupManager_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 73 insertions(+))
google-beta provider: Diff ( 6 files changed, 504 insertions(+))

[modular-magician]

Tests analytics

Total tests: 939
Passed tests: 846
Skipped tests: 72
Affected tests: 21

Click here to see the affected service packages

• compute

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeTargetPool_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Debug log]
TestAccComputeAutoscaler_multicondition[Debug log]
TestAccComputeAutoscaler_scaleDownControl[Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Debug log]
TestAccComputeRegionAutoscaler_update[Debug log]
TestAccComputeTargetPool_basic[Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Debug log]
TestAccInstanceGroupManager_basic[Debug log]
TestAccInstanceGroupManager_self_link_unique[Debug log]
TestAccInstanceGroupManager_stateful[Debug log]
TestAccInstanceGroupManager_update[Debug log]
TestAccInstanceGroupManager_waitForStatus[Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Debug log]
TestAccRegionInstanceGroupManager_basic[Debug log]
TestAccRegionInstanceGroupManager_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 73 insertions(+))
google-beta provider: Diff ( 6 files changed, 504 insertions(+))

[modular-magician]

Tests analytics

Total tests: 939
Passed tests: 864
Skipped tests: 72
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[zli82016]

LGTM. The failed tests are unrelated.

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test