Modify Ruby yaml files to follow the rules to copy comments to Go yam… #11713
+85
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
zli82016
force-pushed
the
go-rewrite-copy-comments
branch
from
6bd4d8e
to
4352f80
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
c2thorn
approved these changes
Sep 16, 2024
abd-goog
pushed a commit
to abd-goog/magic-modules
that referenced
this pull request
Sep 23, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Oct 7, 2024
Philip-Jonany
pushed a commit
to Philip-Jonany/magic-modules
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11715, I store the comments to a map. Each comment has a key. The key is the previous name line + the name line + the line which has the comment.
To make the keys work, the following rules should be followed:
nameshould be the next line of typeThis PR is to make sure the key for the comments is correct.
Release Note Template for Downstream PRs (will be copied)