initial ephemeral poc #11824
initial ephemeral poc #11824
Conversation
|
Making a note: the Go rewrite was just merged into the feature branch via the sync PR. This has caused some conflicts, and the .go.erb files are no longer valid |
SarahFrench
changed the base branch from
FEATURE-BRANCH-ephemeral-resources
to
FEATURE-BRANCH-ephemeral-resource
There was a problem hiding this comment.
Looks like a good start, thanks for opening this PR to show the POC!
I think our next steps should be to:
- Open a PR that adds support for ephemeral resources but includes none.
- Open a PR that pulls out the ephemeral_service_account_access_token work and completes it, along with acc tests, and does that in a way that's not blocked by the muxing fixes
- i.e. we'll get my muxing fixes merged, into the feature branch via a sync, and then rebase any open PRs we have
| return | ||
| } | ||
|
|
||
| // Required for accessing project, region, zone and tokenSource |
There was a problem hiding this comment.
nit
| // Required for accessing project, region, zone and tokenSource |
| // Copyright (c) HashiCorp, Inc. | ||
| // SPDX-License-Identifier: MPL-2.0 | ||
| // Copyright (c) HashiCorp, Inc. | ||
| // SPDX-License-Identifier: MPL-2.0 |
There was a problem hiding this comment.
| // Copyright (c) HashiCorp, Inc. | |
| // SPDX-License-Identifier: MPL-2.0 | |
| // Copyright (c) HashiCorp, Inc. | |
| // SPDX-License-Identifier: MPL-2.0 |
| // EphemeralResources defines the resources that are of ephemral type implemented in the provider. | ||
| func (p *FrameworkProvider) EphemeralResources(_ context.Context) []func() ephemeral.EphemeralResource { | ||
| return []func() ephemeral.EphemeralResource{ | ||
| eph.GoogleEphemeralServiceAccountAccessToken, |
There was a problem hiding this comment.
I know you're aware of it, but making a note: these ephemeral resources should be moved into the same package as the original data sources they resemble.
| @@ -517,6 +517,20 @@ func (p *FrameworkProviderConfig) SetupGrpcLogging() { | |||
| ) | |||
| } | |||
|
|
|||
| func (p *FrameworkProviderConfig) NewIamCredentialsClient(userAgent string) *iamcredentials.Service { | |||
There was a problem hiding this comment.
Once my muxing fixes PR is merged the plugin-framework side of the provider will use the SDK-flavoured Config struct, which already has this method implemented and you can use directly in the code of this PR's work.
There was a problem hiding this comment.
Given the timelines of this project and getting the muxing fixes merged, I think we'll have to go ahead with this as a temporary fix to unblock ourselves 😬
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
initial work of supporting ephemeral resource
service_account_tokenHas the base code for supporting ephemerals which is including in the provider config itslef. Still requires some work on supprting services such as
IAMCredentialsBasePathwhich is crucial for supporting bothservice_account_tokenandservice_account_jwtAlthough this PR covers all of them we should only really focus on
service_account_token.This PR can easily be closed and opened again to make the ephemeral development process much smoother.
Release Note Template for Downstream PRs (will be copied)