[DataprocGdc] Add Terraform support for Dataproc on GDC resources #11989

JerryLeiDing · 2024-10-11T23:06:46Z

This PR adds support for Dataproc on GDC API Service Instances to the GCP Terraform provider.

Release Note Template for Downstream PRs (will be copied)

`google_dataproc_gdc_service_instance`

github-actions · 2024-10-11T23:07:24Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/products/dataprocgdc/ApplicationEnvironment.yaml

modular-magician · 2024-10-31T06:58:52Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccDataprocGdcServiceInstance_dataprocgdcServiceinstanceExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

melinath

Requested a bunch of cleanup below to bring this in line with conventions & make things easier to read. Please also add a top-level references section that links to the API docs and at least one guide.

mmv1/products/dataprocgdc/ServiceInstance.yaml

melinath · 2024-10-31T15:41:15Z

mmv1/products/dataprocgdc/ServiceInstance.yaml

+      per-resource P4SA that also automatically has Fleet Workload\nIdentity bindings
+      applied. "
+    output: true
+parameters:


parameters should come before properties by convention

melinath · 2024-10-31T15:41:32Z

mmv1/products/dataprocgdc/ServiceInstance.yaml

+async:
+  actions: ['create', 'delete']
+  type: OpAsync
+  operation:
+    base_url: "{{op_id}}"
+immutable: true
+examples:
+  - name: "dataprocgdc_serviceinstance"
+    primary_resource_id: "service-instance"
+    vars:
+      service_instance_id: "tf-e2e-service-instance"
+      project: "my-project"
+    test_vars_overrides:
+      'project': '"gdce-cluster-monitoring"'


these should all go before parameters by convention

mmv1/products/dataprocgdc/product.yaml

mmv1/products/dataprocgdc/ServiceInstance.yaml

modular-magician · 2024-10-31T18:23:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1229 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1219 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 135 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

modular-magician · 2024-10-31T19:36:30Z

Tests analytics

Total tests: 4245
Passed tests: 3816
Skipped tests: 420
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApphubWorkload_apphubWorkloadBasicExample

TestAccApphubWorkload_apphubWorkloadFullExample

TestAccApphubWorkload_apphubWorkloadUpdate

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccDataSourceApphubDiscoveredWorkload_basic

TestAccDataprocGdcServiceInstance_dataprocgdcServiceinstanceExample

TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample

TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

TestAccNetworkServicesLbTrafficExtension_update

Get to know how VCR tests work

modular-magician · 2024-10-31T20:01:02Z

🟢 Tests passed during RECORDING mode:
TestAccApphubWorkload_apphubWorkloadBasicExample [Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample [Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic [Debug log]
TestAccDataprocGdcServiceInstance_dataprocgdcServiceinstanceExample [Debug log]
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample [Debug log]
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample [Debug log]
TestAccNetworkServicesLbTrafficExtension_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

melinath

A couple small items - please also add the previously-requested references: #11989 (review)

melinath · 2024-10-31T20:31:59Z

mmv1/products/dataprocgdc/ServiceInstance.yaml

+    output: true
+  - name: state
+    type: String
+    description: "The current state. \n Possible values:\n STATE_UNSPECIFIED\nCREATING\nACTIVE\nDISCONNECTED\nDELETING\nSTOPPING\nSTOPPED\nSTARTING\nUPDATING\nFAILED"


please update this as well

melinath · 2024-10-31T20:32:19Z

mmv1/products/dataprocgdc/ServiceInstance.yaml

+      This will be\nthe service_account if specified. Otherwise, it will be an automatically\ncreated
+      per-resource P4SA that also automatically has Fleet Workload\nIdentity bindings


Suggested change

This will be\nthe service_account if specified. Otherwise, it will be an automatically\ncreated

per-resource P4SA that also automatically has Fleet Workload\nIdentity bindings

This will be the service_account if specified. Otherwise, it will be an automatically created

per-resource P4SA that also automatically has Fleet Workload Identity bindings

JerryLeiDing · 2024-10-31T21:53:10Z

A couple small items - please also add the previously-requested references: #11989 (review)

I added a link to our user guide. The API documentation is not available yet, but I can link to where the page will be if that helps.

melinath · 2024-10-31T21:57:13Z

The API documentation is not available yet, but I can link to where the page will be if that helps.

Yeah, if you have that handy (and it's not going to change) that would be great - otherwise someone would need to come along and add it later.

modular-magician · 2024-10-31T22:03:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1222 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1212 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 135 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

JerryLeiDing · 2024-10-31T22:24:09Z

The API documentation is not available yet, but I can link to where the page will be if that helps.

Yeah, if you have that handy (and it's not going to change) that would be great - otherwise someone would need to come along and add it later.

Done

modular-magician · 2024-10-31T22:35:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1224 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1214 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 135 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

modular-magician · 2024-10-31T23:16:09Z

Tests analytics

Total tests: 4245
Passed tests: 3824
Skipped tests: 420
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician · 2024-10-31T23:23:53Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-10-31T23:48:59Z

Tests analytics

Total tests: 4245
Passed tests: 3825
Skipped tests: 420
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🟢 All tests passed!

View the build log

melinath

I can't validate the schema since the docs don't exist yet, but this resource seems to be working fine in tests. Thanks!

…ogleCloudPlatform#11989) Co-authored-by: Jerry Ding <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

github-actions bot requested a review from rileykarson October 11, 2024 23:07

JerryLeiDing force-pushed the dataproc-gdc branch 2 times, most recently from cc193ef to 2466249 Compare October 11, 2024 23:36

This comment was marked as outdated.

Sign in to view

rileykarson reviewed Oct 17, 2024

View reviewed changes

mmv1/products/dataprocgdc/ApplicationEnvironment.yaml Outdated Show resolved Hide resolved

JerryLeiDing force-pushed the dataproc-gdc branch from 2466249 to 5066214 Compare October 21, 2024 00:32

github-actions bot requested a review from rileykarson October 21, 2024 00:32

This comment was marked as outdated.

Sign in to view

JerryLeiDing force-pushed the dataproc-gdc branch 2 times, most recently from 480f575 to a052996 Compare October 21, 2024 19:30

This comment was marked as outdated.

Sign in to view

JerryLeiDing force-pushed the dataproc-gdc branch 2 times, most recently from 286024b to 21aa248 Compare October 21, 2024 19:37

This comment was marked as outdated.

Sign in to view

JerryLeiDing force-pushed the dataproc-gdc branch from 21aa248 to b3af720 Compare October 22, 2024 23:29

This comment was marked as outdated.

Sign in to view

melinath requested changes Oct 31, 2024

View reviewed changes

github-actions bot requested a review from melinath October 31, 2024 17:21

JerryLeiDing force-pushed the dataproc-gdc branch 2 times, most recently from a416bff to 90d64c5 Compare October 31, 2024 18:12

melinath requested changes Oct 31, 2024

View reviewed changes

JerryLeiDing force-pushed the dataproc-gdc branch from 90d64c5 to a8ef1b7 Compare October 31, 2024 21:53

github-actions bot requested a review from melinath October 31, 2024 21:53

Apply suggestions from code review

43f3591

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

JerryLeiDing force-pushed the dataproc-gdc branch from a8ef1b7 to 43f3591 Compare October 31, 2024 22:24

melinath approved these changes Nov 1, 2024

View reviewed changes

melinath merged commit 198e6d5 into GoogleCloudPlatform:main Nov 1, 2024
15 of 16 checks passed

		This will be\nthe service_account if specified. Otherwise, it will be an automatically\ncreated
		per-resource P4SA that also automatically has Fleet Workload\nIdentity bindings

[DataprocGdc] Add Terraform support for Dataproc on GDC resources #11989

[DataprocGdc] Add Terraform support for Dataproc on GDC resources #11989

Conversation

JerryLeiDing commented Oct 11, 2024 • edited Loading

github-actions bot commented Oct 11, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

modular-magician commented Oct 31, 2024

melinath left a comment

Choose a reason for hiding this comment

melinath Oct 31, 2024

Choose a reason for hiding this comment

melinath Oct 31, 2024

Choose a reason for hiding this comment

modular-magician commented Oct 31, 2024

Diff report

modular-magician commented Oct 31, 2024

Tests analytics

Action taken

modular-magician commented Oct 31, 2024

melinath left a comment

Choose a reason for hiding this comment

melinath Oct 31, 2024

Choose a reason for hiding this comment

JerryLeiDing Oct 31, 2024

Choose a reason for hiding this comment

melinath Oct 31, 2024

Choose a reason for hiding this comment

JerryLeiDing Oct 31, 2024

Choose a reason for hiding this comment

JerryLeiDing commented Oct 31, 2024

melinath commented Oct 31, 2024

modular-magician commented Oct 31, 2024

Diff report

JerryLeiDing commented Oct 31, 2024

modular-magician commented Oct 31, 2024

Diff report

modular-magician commented Oct 31, 2024

Tests analytics

Action taken

modular-magician commented Oct 31, 2024

modular-magician commented Oct 31, 2024

Tests analytics

melinath left a comment

Choose a reason for hiding this comment

JerryLeiDing commented Oct 11, 2024 •

edited

Loading