Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform] Add more OAuth2 credential options. #1201

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jan 8, 2019


[all]

[terraform]

Add OAuth2 access_token and client config as credential options.

[terraform-beta]

Add OAuth2 access_token and client config as credential options.

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#330
depends: hashicorp/terraform-provider-google#2838

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 63fa64d) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2ddc5d1) have been included in your existing downstream PRs.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems generally sensible- I just had one question inline, and another about how we're testing this. Is it infeasible to test?

third_party/terraform/utils/config.go.erb Show resolved Hide resolved
@emilymye emilymye force-pushed the tf_auth_access_token branch 2 times, most recently from 3676c48 to 600c395 Compare January 9, 2019 22:12
@emilymye
Copy link
Contributor Author

emilymye commented Jan 9, 2019

@rileykarson added some acc tests for config. Not really sure if I like this test but it's config-specific enough to put in config_test.go?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like the right place, and the test looks reasonable enough; can you add docs as well to https://www.terraform.io/docs/providers/google/provider_reference.html#configuration-reference?

@emilymye
Copy link
Contributor Author

emilymye commented Jan 9, 2019

make testacc TEST=./google TESTARGS='--run="TestAccConfig"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v --run="TestAccConfig" -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN TestAccConfigLoadValidate_credentials
--- PASS: TestAccConfigLoadValidate_credentials (0.69s)
=== RUN TestAccConfigLoadValidate_accessToken
--- PASS: TestAccConfigLoadValidate_accessToken (0.19s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 1.326s

@emilymye emilymye force-pushed the tf_auth_access_token branch 5 times, most recently from a696892 to 26b1335 Compare January 10, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants