-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terraform] Add more OAuth2 credential options. #1201
[Terraform] Add more OAuth2 credential options. #1201
Conversation
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
da3081f
to
fa12754
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 63fa64d) have been included in your existing downstream PRs. |
fa12754
to
f75fd17
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 2ddc5d1) have been included in your existing downstream PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally sensible- I just had one question inline, and another about how we're testing this. Is it infeasible to test?
3676c48
to
600c395
Compare
@rileykarson added some acc tests for config. Not really sure if I like this test but it's config-specific enough to put in config_test.go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like the right place, and the test looks reasonable enough; can you add docs as well to https://www.terraform.io/docs/providers/google/provider_reference.html#configuration-reference?
99dd659
to
36fe8f5
Compare
make testacc TEST=./google TESTARGS='--run="TestAccConfig"' |
a696892
to
26b1335
Compare
26b1335
to
0162cbf
Compare
[all]
[terraform]
Add OAuth2 access_token and client config as credential options.
[terraform-beta]
Add OAuth2 access_token and client config as credential options.
[ansible]
[inspec]