-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow proper changing of google_compute_region_instance_group_manager.distribution_policy_target_shape #12050
Allow proper changing of google_compute_region_instance_group_manager.distribution_policy_target_shape #12050
Conversation
….distribution_policy_target_shape
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
...hird_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.tmpl
Outdated
Show resolved
Hide resolved
...party/terraform/services/compute/resource_compute_region_instance_group_manager_test.go.tmpl
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1036 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1036 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
fix indent even more
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1036 Click here to see the affected service packages
🟢 All tests passed! View the build log |
...hird_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.tmpl
Outdated
Show resolved
Hide resolved
…ble, and the field is marked in TFas ForceNew
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1036 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fixing.
….distribution_policy_target_shape (GoogleCloudPlatform#12050)
….distribution_policy_target_shape (GoogleCloudPlatform#12050)
….distribution_policy_target_shape (GoogleCloudPlatform#12050)
….distribution_policy_target_shape (GoogleCloudPlatform#12050)
Allow proper changing of google_compute_region_instance_group_manager.distribution_policy_target_shape. Effectively - don't send the zones distribution when ONLY target shape changes.
fixes #19891
Release Note Template for Downstream PRs (will be copied)