Add instanceFlexibilityPolicy to google_compute_region_instance_group_manager

[chayankumar999]

Add instanceFlexibilityPolicy to google_compute_region_instance_group_manager to create instances by instanceSelections in Beta API

Release Note Template for Downstream PRs (will be copied)

compute: added new field `instance_flexibility_policy` to resource `google_compute_region_instance_group_manager`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 354 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 354 insertions(+), 1 deletion(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 1041
Passed tests: 939
Skipped tests: 73
Affected tests: 29

Click here to see the affected service packages

• compute

Action taken

Found 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeForwardingRule_forwardingRuleHttpLbExample
• TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
• TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
• TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
• TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
• TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
• TestAccComputeRegionAutoscaler_scaleDownControl
• TestAccComputeRegionAutoscaler_scaleInControl
• TestAccComputeRegionAutoscaler_scalingSchedule
• TestAccComputeRegionAutoscaler_update
• TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample
• TestAccComputeRegionBackendService_withBackendInternalManaged
• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccComputeRegionPerInstanceConfig_statefulIps
• TestAccComputeRegionPerInstanceConfig_update
• TestAccDataSourceGoogleComputeRegionInstanceGroupManager
• TestAccRegionInstanceGroupManager_APISideListRecordering
• TestAccRegionInstanceGroupManager_autoHealingPolicies
• TestAccRegionInstanceGroupManager_basic
• TestAccRegionInstanceGroupManager_distributionPolicy
• TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy
• TestAccRegionInstanceGroupManager_resourceManagerTags
• TestAccRegionInstanceGroupManager_stateful
• TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize
• TestAccRegionInstanceGroupManager_targetSizeZero
• TestAccRegionInstanceGroupManager_update
• TestAccRegionInstanceGroupManager_versions

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeForwardingRule_forwardingRuleHttpLbExample [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample [Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate [Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample [Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl [Debug log]
TestAccComputeRegionAutoscaler_scaleInControl [Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule [Debug log]
TestAccComputeRegionAutoscaler_update [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample [Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps [Debug log]
TestAccComputeRegionPerInstanceConfig_update [Debug log]
TestAccDataSourceGoogleComputeRegionInstanceGroupManager [Debug log]
TestAccRegionInstanceGroupManager_APISideListRecordering [Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies [Debug log]
TestAccRegionInstanceGroupManager_basic [Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy [Debug log]
TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy [Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags [Debug log]
TestAccRegionInstanceGroupManager_stateful [Debug log]
TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize [Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero [Debug log]
TestAccRegionInstanceGroupManager_update [Debug log]
TestAccRegionInstanceGroupManager_versions [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 353 insertions(+), 1 deletion(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 1045
Passed tests: 970
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 353 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 1045
Passed tests: 970
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[rileykarson]

Those failing tests are unrelated, you can ignore them.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 352 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[pjotrekk]

Sorry if there are some trivial or misleading comments - I don't review the TF code too often and a lot of things are unclear to me.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 352 insertions(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 350 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 354 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[rileykarson]

LGTM- @pjotrekk I'll wait for confirmation from you as well to merge.

[chayankumar999]

Btw, some checks are failing here regarding version tag. Let me fix them first.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 347 insertions(+), 7 deletions(-))

[chayankumar999]

Btw, some checks are failing here regarding version tag. Let me fix them first.

Done! Checks are passing now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 347 insertions(+), 7 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 347 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1055
Passed tests: 982
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 1055
Passed tests: 982
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 1055
Passed tests: 982
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log