Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil IAP in backend service decoder #1667

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 18, 2019

Fixes hashicorp/terraform-provider-google#3441

comment by @rileykarson: Annoyingly, the block is a case where it defaults to disabled so we ran into this error when a user had used an old resource; users could also encounter it when importing though. We've sent a default block since version 1.2 of the provider, so on any resources created since this was a non-issue.


[all]

[terraform]

Handle nil IAP in backend service decoder

[terraform-beta]

Handle nil IAP in backend service decoder

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7e21c2a.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#622
depends: hashicorp/terraform-provider-google#3459

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 26bbf27 into GoogleCloudPlatform:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackendService crash from blank IAP value in 2.4.0
4 participants