Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Pubsub Topic labels update #1900

Merged

Conversation

drebes
Copy link
Member

@drebes drebes commented Jun 10, 2019

Fixes hashicorp/terraform-provider-google#3210

It's not documented that Pubsub Topics support PATCH/update, but they do.

$ make testacc TEST=./google TESTARGS='-run=TestAccPubsubTopic_update'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccPubsubTopic_update -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccPubsubTopic_update
=== PAUSE TestAccPubsubTopic_update
=== CONT  TestAccPubsubTopic_update
--- PASS: TestAccPubsubTopic_update (15.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	15.776s

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of fd9f9f66a15e003f704e7b826dafcc2b6b4c9118.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#832
depends: hashicorp/terraform-provider-google#3828
depends: modular-magician/ansible#274

@chrisst
Copy link
Contributor

chrisst commented Jun 10, 2019

Given the custom update encoder I'm not sure if this will work right away with Ansible so adding @rambleraptor to the review as well.
It looks like the whole object is wrapped inside topic for the update to work.

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform code looks good tho!

@chrisst
Copy link
Contributor

chrisst commented Jun 13, 2019

@drebes can you deal with the merge conflicts and I'll merge this

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fc0b5f5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#109

@drebes
Copy link
Member Author

drebes commented Jun 14, 2019

Done, good to merge.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 7747035 into GoogleCloudPlatform:master Jun 14, 2019
@drebes drebes deleted the pubsub-update-labels branch June 14, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PubSub topic does not support Update
5 participants