Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote internal global addresses to GA #1937

Merged
merged 3 commits into from
Jun 19, 2019
Merged

promote internal global addresses to GA #1937

merged 3 commits into from
Jun 19, 2019

Conversation

danawillow
Copy link
Contributor

This fixes the TestAccServiceNetworkingConnection tests, which are failing in GA.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 0591aad.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#866
depends: GoogleCloudPlatform/terraform-google-conversion#112
depends: hashicorp/terraform-provider-google#3877
depends: modular-magician/ansible#283
depends: modular-magician/inspec-gcp#165

chrisst
chrisst approved these changes Jun 19, 2019
View reviewed changes
products/compute/api.yaml Outdated
values:
- :GCE_ENDPOINT
- :DNS_RESOLVER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I originally added this these options weren't fully supported yet. I'm assuming if they are documented in the GA docs then they should be working but might want to double check.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 57f2f6d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit 27e144b into GoogleCloudPlatform:master Jun 19, 2019
@danawillow danawillow deleted the service-networking-test branch June 19, 2019 01:59
@modular-magician modular-magician mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danawillow @modular-magician @chrisst @googlebot