add advanced routing options to router peer #2271
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| } | ||
| interface = "${google_compute_router_interface.foobar.name}" | ||
| } | ||
| `, testId, testId, testId, testId, testId, testId, testId, testId, testId, testId, testId) |
There was a problem hiding this comment.
This would be a lot cleaner with the context map that some other tests use, but its all the same string and changing it would require changing the other tests in this file so 🤷♂
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
megan_advanced_routing
branch
from
8813906
to
5705443
Compare
|
@megan07 no doc update for this? I've suddenly got existing resources wanting to rebuild because the unset value now wants to be set to "DEFAULT" |
|
Hi @allandrick , thank you for bringing this to our attention! I’m sorry you had a bad upgrade experience, we try our best to avoid that, but in this case it looks like this slipped through. We’re looking into what the best approach is going forward. Meanwhile, I will update the documentation as well and add these 3 fields. Would you please create a new issue in the terraform-providers-google repo so we can track it along with the other issues? We will update that with further information and remediation efforts. Thanks again! |
|
Thanks @megan07! issue created. |
Fixes hashicorp/terraform-provider-google#4357
Updated the
google_compute_router_peerto include the full routing options, similar to what exists ingoogle_compute_routerRelease Note for Downstream PRs (will be copied)