Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Build Trigger's trigger template should be required. #2352

Merged
merged 1 commit into from
Sep 24, 2019
+1 −3
Merged

Cloud Build Trigger's trigger template should be required. #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions products/cloudbuild/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ objects:
Branch and tag names in trigger templates are interpreted as regular
expressions. Any branch or tag change that matches that regular
expression will trigger a build.
required: true
properties:
- !ruby/object:Api::Type::String
name: 'projectId'
Expand Down
3 changes: 0 additions & 3 deletions products/cloudbuild/terraform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
name: 'trigger_id'
build.steps: !ruby/object:Overrides::Terraform::PropertyOverride
name: 'step'
triggerTemplate: !ruby/object:Overrides::Terraform::PropertyOverride
description: |
{{description}}This field is required, and will be validated as such in 3.0.0.
triggerTemplate.projectId: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
custom_code: !ruby/object:Provider::Terraform::CustomCode
Expand Down