Perform deprecation of GKE subnetwork creation #2562

rileykarson · 2019-10-29T21:56:48Z

Part of hashicorp/terraform-provider-google#4638

Release Note Template for Downstream PRs (will be copied)

`container`: deprecated `google_container_cluster` `ip_allocation_policy.use_ip_aliases`. If it's set to true, remove it from your config. If false, remove `ip_allocation_policy` as a whole.

`container`: deprecated `google_container_cluster` `ip_allocation_policy.create_subnetwork`, `ip_allocation_policy.subnetwork_name`, `ip_allocation_policy.node_ipv4_cidr_block`. Define an explicit `google_compute_subnetwork` and use `subnetwork` instead.

modular-magician · 2019-10-29T22:08:17Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cb981b7.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1312
depends: hashicorp/terraform-provider-google#4774

modular-magician · 2019-10-30T18:38:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0420626.

Pull request statuses

WARNING: The following files changed in commit 0420626 may need corresponding changes in third_party/validator:

third_party/terraform/resources/resource_container_cluster.go.erb

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-10-30T19:47:27Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a0fbf05.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-10-30T20:18:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f140d8c.

Pull request statuses

WARNING: The following files changed in commit f140d8c may need corresponding changes in third_party/validator:

third_party/terraform/resources/resource_container_cluster.go.erb

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow · 2019-11-01T22:38:42Z

third_party/terraform/tests/resource_container_cluster_test.go.erb

@@ -1344,6 +1344,15 @@ func TestAccContainerCluster_withIPAllocationPolicy_createSubnetwork(t *testing.
 				ImportState:		 true,
 				ImportStateVerify:	 true,
 			},
+			{
+				Config: testAccContainerCluster_withIPAllocationPolicy_createSubnetworkUpdated(cluster),


From what I can tell, this test is to confirm that you can move things out of the old block and set it by using the subnetwork field. Would a PlanOnly test make more sense here (to check a lack of diffs), or are we expecting the change to actually perform an update? Also if I'm way off the mark, a comment explaining the purpose of the test would be appreciated.

You got it right- I'd forgotten that PlanOnly was a thing.

third_party/terraform/website/docs/version_3_upgrade.html.markdown

modular-magician · 2019-11-04T18:24:15Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 66c9526.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

third_party/terraform/tests/resource_container_cluster_test.go.erb

danawillow · 2019-11-04T18:36:40Z

third_party/terraform/tests/resource_container_cluster_test.go.erb

 			},
 			{
-				ResourceName:		 "google_container_cluster.with_ip_allocation_policy",
+				ResourceName:		     "google_container_cluster.with_ip_allocation_policy",


do we still want this import step given that the previous was planonly?

🤷‍♀ it's probably entirely redundant, but import is free and running ISV another time is nice.

modular-magician · 2019-11-04T19:08:38Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2613362.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

…eprecation

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Oct 29, 2019

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Oct 29, 2019

rileykarson requested a review from danawillow October 30, 2019 22:03

danawillow approved these changes Nov 1, 2019

View reviewed changes

danawillow reviewed Nov 4, 2019

View reviewed changes

third_party/terraform/tests/resource_container_cluster_test.go.erb Outdated Show resolved Hide resolved

danawillow reviewed Nov 4, 2019

View reviewed changes

modular-magician added the automerged label Nov 4, 2019

rileykarson and others added 7 commits November 4, 2019 22:22

Add deprecation messages, upgrade guide for GKE subnetwork creation d…

237653f

…eprecation

Amend behaviour, add test

8d1dbcd

Amend messaging

6ce2723

Fix schema, remove custom diff

a66e59f

Doc fixes, planonly

26af9f9

Fix indentation

ca52aa5

Update tracked submodules -> HEAD on Mon Nov 4 22:22:05 UTC 2019

838af0c

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the gke-subnetwork-deprecation branch from 2613362 to 838af0c Compare November 4, 2019 22:22

modular-magician merged commit 253b277 into GoogleCloudPlatform:master Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perform deprecation of GKE subnetwork creation #2562

Perform deprecation of GKE subnetwork creation #2562

rileykarson commented Oct 29, 2019

modular-magician commented Oct 29, 2019

modular-magician commented Oct 30, 2019

modular-magician commented Oct 30, 2019

modular-magician commented Oct 30, 2019

danawillow Nov 1, 2019

rileykarson Nov 4, 2019

modular-magician commented Nov 4, 2019

danawillow Nov 4, 2019

rileykarson Nov 4, 2019

modular-magician commented Nov 4, 2019

Perform deprecation of GKE subnetwork creation #2562

Perform deprecation of GKE subnetwork creation #2562

Conversation

rileykarson commented Oct 29, 2019

modular-magician commented Oct 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 30, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 30, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 30, 2019

Pull request statuses

New Pull Requests

danawillow Nov 1, 2019

Choose a reason for hiding this comment

rileykarson Nov 4, 2019

Choose a reason for hiding this comment

modular-magician commented Nov 4, 2019

Pull request statuses

New Pull Requests

danawillow Nov 4, 2019

Choose a reason for hiding this comment

rileykarson Nov 4, 2019

Choose a reason for hiding this comment

modular-magician commented Nov 4, 2019

Pull request statuses

New Pull Requests