Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hand written docs to reflect newly required fields #2682

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Nov 13, 2019

These should be the last of the nested objects.

Some assumptions I made along the way:
google_composer_environment.config.node_config.ip_allocation.use_ip_aliases I made required, the other 4 seem to be grouped by 2 and conflict with each other, so I figured this was the safest one to make mandatory.

I realized when adding at_least_one_of and exactly_one_of to magic modules, it doesn't update anything in the docs. So I didn't update anything in the handwritten docs either (mostly for the time crunch, but with the excuse for consistency). I can update that there though, not sure if we want to document it on each field, or at the parent resource level.

Release Note Template for Downstream PRs (will be copied)

`iam`: Made exactly one of `allow` or `deny` required on `google_organization_policy.list_policy`
`composer`: Made at least one of `enable_private_endpoint` or `master_ipv4_cidr_block` required on `google_composer_environment.config.private_environment_config`
Made exactly one of `daily_maintenance_window` or `recurring_window` required on `google_container_cluster.maintenance_policy`
`composer`: Made at least one of `node_count`, `node_config`, `software_config` or `private_environment_config` required on `google_composer_environment.config`

@nat-henderson
Copy link
Contributor

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e9e1564.

Pull request statuses

WARNING: The following files changed in commit e9e1564 may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_container_cluster.go.erb

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1382
depends: hashicorp/terraform-provider-google#4896
depends: ansible-collections/google.cloud#73

megan07 and others added 3 commits November 14, 2019 01:42
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants