Add route_rules to UrlMap for Traffic Director #2748

tysen · 2019-11-25T23:21:30Z

Release Note Template for Downstream PRs (will be copied)

`google_compute_url_map` now supports header actions and route rules.

modular-magician · 2019-11-25T23:30:50Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4b0a0cd.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1435
depends: GoogleCloudPlatform/terraform-google-conversion#269
depends: hashicorp/terraform-provider-google#4992
depends: ansible-collections/google.cloud#95
depends: modular-magician/inspec-gcp#256

rileykarson

Made a pass of resource schema. For repeated headerAction blocks, any comments on the first apply to the rest.

products/compute/api.yaml

templates/terraform/examples/url_map_traffic_director_route.tf.erb

products/compute/api.yaml

rileykarson · 2019-12-02T21:31:49Z

products/compute/api.yaml

+                          Specifies the retry policy associated with this route.
+                        properties:
+                          - !ruby/object:Api::Type::Integer
+                            name: 'numRetries'


Are this & the below value required? Do they take on defaults when not specified?

I updated the docs for perTryTimeout and made numRetries required.

rileykarson · 2019-12-02T21:33:00Z

products/compute/api.yaml

+                          the matched service
+                        properties:
+                          - !ruby/object:Api::Type::String
+                            name: 'hostRewrite'


The value must be between 1 and 255 characters. suggests the field is Required?

I don't think so. There are different portions of the URL that can be replaced (host, path, and prefix) and none are required.

products/compute/api.yaml

rileykarson

If possible, can you structure changes based on review comments as separate commits? It's hard to see the diff of the changes when they've been squashed in, and means I have to look over the entire original change and try and remember what it looked like before. https://github.com/GoogleCloudPlatform/magic-modules/compare/4b0a0cd45fa6d6a13eb709a2cbf163b888cf901b..b9ea89349df85fbebc6c96ad490d22b50a85c9ad makes it possible, but munges the changes with whatever you picked up from upstream.

A model I use a lot of the time is that I create a commit per-push including my changes (breaking it up more granularly if needed) and rebase+force push if I've fallen out of date with master.

products/compute/api.yaml

rileykarson · 2019-12-04T23:25:04Z

Can you rebase + force-push so generation works again?

tysen · 2019-12-04T23:36:14Z

Done.

modular-magician · 2019-12-04T23:45:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 63c7353.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

Just a couple small comments left 🎉

products/compute/api.yaml

rileykarson · 2019-12-06T19:05:55Z

products/compute/api.yaml

@@ -11509,6 +11513,8 @@ objects:
    description: |
      UrlMaps are used to route requests to a backend service based on rules
      that you define for the host and path of an incoming URL.
+    references: !ruby/object:Api::Resource::ReferenceLinks
+      api: https://cloud.google.com/compute/docs/reference/rest/v1/urlMaps
    async: !ruby/object:Api::OpAsync
      operation: !ruby/object:Api::OpAsync::Operation
        kind: 'compute#operation'


note for myself: GitHub is skipping a bunch of lines here with no indicator

third_party/terraform/tests/resource_compute_url_map_test.go.erb

modular-magician · 2019-12-06T19:48:08Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 256cd6b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-06T20:27:59Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2ae35b2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

tysen requested a review from rileykarson November 25, 2019 23:21

googlebot added the cla: yes label Nov 25, 2019

modular-magician added downstream-generated ansible inspec terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Nov 25, 2019

rileykarson reviewed Dec 2, 2019

View reviewed changes

tysen requested a review from rileykarson December 2, 2019 23:51

rileykarson reviewed Dec 4, 2019

View reviewed changes

products/compute/api.yaml Show resolved Hide resolved

products/compute/api.yaml Show resolved Hide resolved

tysen requested a review from rileykarson December 4, 2019 23:23

rileykarson reviewed Dec 6, 2019

View reviewed changes

tysen requested a review from rileykarson December 6, 2019 19:38

rileykarson approved these changes Dec 6, 2019

View reviewed changes

modular-magician added the automerged label Dec 6, 2019

Ty Larrabee and others added 5 commits December 6, 2019 20:35

Add route_rules to UrlMap for Traffic Director

4d80d30

Update other headerAction blocks

1789259

Modify tests

437eba3

Remove unless blocks from tests

1232c5c

Update tracked submodules -> HEAD on Fri Dec 6 20:35:25 UTC 2019

1f01a06

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician merged commit 1d93b45 into GoogleCloudPlatform:master Dec 6, 2019

tysen mentioned this pull request Dec 10, 2019

Add route_rules to RegionUrlMap #2807

Merged

modular-magician mentioned this pull request Dec 10, 2019

Bug fixes for GCP (as of 2019-11-14T07:04:56Z) ansible/ansible#65681

Merged

modular-magician mentioned this pull request Dec 13, 2019

Bug fixes for GCP (as of 2019-11-14T07:04:56Z) ansible/ansible#65792

Merged

This was referenced Feb 12, 2020

New GCP module: gcp_bigtable_instance ansible/ansible#67332

Closed

New GCP module: gcp_bigtable_instance_info ansible/ansible#67333

Closed

Bug fixes for GCP (as of 2019-11-14T07:04:56Z) ansible/ansible#67562

Closed

modular-magician mentioned this pull request Mar 4, 2020

New GCP module: gcp_storage_default_object_acl ansible/ansible#67988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add route_rules to UrlMap for Traffic Director #2748

Add route_rules to UrlMap for Traffic Director #2748

tysen commented Nov 25, 2019

modular-magician commented Nov 25, 2019

rileykarson left a comment

rileykarson Dec 2, 2019

tysen Dec 2, 2019

rileykarson Dec 2, 2019

tysen Dec 2, 2019

rileykarson left a comment

rileykarson commented Dec 4, 2019

tysen commented Dec 4, 2019

modular-magician commented Dec 4, 2019

rileykarson left a comment

rileykarson Dec 6, 2019

modular-magician commented Dec 6, 2019

modular-magician commented Dec 6, 2019

Add route_rules to UrlMap for Traffic Director #2748

Add route_rules to UrlMap for Traffic Director #2748

Conversation

tysen commented Nov 25, 2019

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Dec 2, 2019

Choose a reason for hiding this comment

tysen Dec 2, 2019

Choose a reason for hiding this comment

rileykarson Dec 2, 2019

Choose a reason for hiding this comment

tysen Dec 2, 2019

Choose a reason for hiding this comment

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson commented Dec 4, 2019

tysen commented Dec 4, 2019

modular-magician commented Dec 4, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Dec 6, 2019

Choose a reason for hiding this comment

modular-magician commented Dec 6, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 6, 2019

Pull request statuses

New Pull Requests