-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move enable_logging to GA for compute_firewall_rule #2752
Move enable_logging to GA for compute_firewall_rule #2752
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Inspec. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Like 100% odds they add stuff to the block, but there's not much we can do about that. I think when they do, we want to deprecate this field and do the same thing as subnetwork where it's enabled if the block is defined.
products/compute/api.yaml
Outdated
This field denotes whether to enable logging for a particular | ||
firewall rule. If logging is enabled, logs will be exported to | ||
Stackdriver. | ||
send_empty_value: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: mind putting description last?
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
b97f137
to
9df8be7
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
9df8be7
to
0680d56
Compare
Involves adding
logConfig.enable
and renaming it toenable_logging
to match the beta-only deprecated version.logConfig.enable
is the only field available for this in GA, and I prefer renaming the field and flattening to prevent breaking beta configs.Release Note Template for Downstream PRs (will be copied)