Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on create op for endpoint service #2886

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

emilymye
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#5039

  • Add wait on Services.Create() operation
  • Move ConfigSource parsing into an expand func

Test-only changes:

  • Add CheckDestroy to tests
  • Refactoring, including changing config functions to use numbered argument in fmt.Sprintf

Release Note Template for Downstream PRs (will be copied)

endpoints: Added operation wait for `google_endpoints_service` to fix 403 "Service not found" errors during initial creation

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f98de1b.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1560
depends: hashicorp/terraform-provider-google#5259

emilymye and others added 2 commits December 26, 2019 23:27
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccEndpointsService_*
4 participants