-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add google_kms_secret_ciphertext resource, deprecate datasource #2912
add google_kms_secret_ciphertext resource, deprecate datasource #2912
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Inspec. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Mostly LGTM, just a couple of question/notes |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
I added a few more changes (google.erb sigh, a deprecation warning in the docs, and removing from validator)- I don't anticipate any comments so going ahead with the merge. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
8feaa47
to
8f7a3b0
Compare
Fixes hashicorp/terraform-provider-google#4436.
Release Note Template for Downstream PRs (will be copied)