Added attempt deadline to scheduler resource

[guillaumeblaquiere]

added attempt deadline to scheduler resource

I didn't touch the auto-generated files. I based my updates on a similar field "time-zone".

Open to any remarks.
Thanks

scheduler: Added `attempt_deadline` to `google_cloud_scheduler_job`.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

[guillaumeblaquiere]

@emilymye Thanks for your review. I pushed fixes.

Do you need I close your previous remarks or I comment them? Tell me how do you want to proceed.

[emilymye]

no worries, i went ahead and resolved the conversations. I'll comment again if I find something that needs changing but otherwise LGTM - im going to start the downstream generation

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, dfe3bfd.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1639
depends: GoogleCloudPlatform/terraform-google-conversion#323
depends: hashicorp/terraform-provider-google#5399
depends: ansible-collections/google.cloud#139
depends: modular-magician/inspec-gcp#309

[emilymye]

Hi @guillaumeblaquiere, it looks mostly good! I ran the tests and there's an issue with the API where if you set the value to the default, it returns nothing for attemptDeadline, which is unfortunate.

There are a a couple things I'll need from you:

1. Please add a diff suppress to the attemptDeadline here

   magic-modules/products/cloudscheduler/terraform.yaml

   Lines 51 to 66 in 142ec17

   	properties:
   	name: !ruby/object:Overrides::Terraform::PropertyOverride
   	custom_expand: 'templates/terraform/custom_expand/shortname_to_url.go.erb'
   	custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb'
   	httpTarget.headers: !ruby/object:Overrides::Terraform::PropertyOverride
   	custom_flatten: 'templates/terraform/custom_flatten/http_headers.erb'
   	validation: !ruby/object:Provider::Terraform::Validation
   	function: 'validateHttpHeaders()'
   	httpTarget.oauthToken: !ruby/object:Overrides::Terraform::PropertyOverride
   	diff_suppress_func: 'authHeaderDiffSuppress'
   	httpTarget.oidcToken: !ruby/object:Overrides::Terraform::PropertyOverride
   	diff_suppress_func: 'authHeaderDiffSuppress'
   	appEngineHttpTarget.headers: !ruby/object:Overrides::Terraform::PropertyOverride
   	custom_flatten: 'templates/terraform/custom_flatten/http_headers.erb'
   	validation: !ruby/object:Provider::Terraform::Validation
   	function: 'validateHttpHeaders()'

it should look like

properties:
  ...
  attemptDeadline: !ruby/object:Overrides::Terraform::PropertyOverride
    diff_suppress_func: 'emptyOrDefaultStringSuppress("180s")'

2. Can you comment on release-note:enhancement added attempt deadline to scheduler resource terraform-google-conversion#323 that you accept the CLA (see the bot comment)? We have a bunch of repos that we generate changes into and it needs to verify CLA for each one.

[guillaumeblaquiere]

@googlebot I fixed it.

[guillaumeblaquiere]

@emilymye, bot says me that:

cla/google — All necessary CLAs are signed

I still use the key work I fixed it to force a check (saw in my first PR because I commited with my company email and not my personal email address)
-> (edit): I didn't understand your message. Now I followed your link and I consent to the CLA in the other branch/repo

Anyway, tell me if it's OK or if I need to perform more action (for the bot or in the code)

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9ae963c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ea6a2b6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.