Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add defaultEventBasedHold to storage buckets #2954

Merged
merged 2 commits into from
Jan 16, 2020
Merged

add defaultEventBasedHold to storage buckets #2954

merged 2 commits into from
Jan 16, 2020

Conversation

MartinNowak
Copy link
Contributor

@MartinNowak MartinNowak commented Jan 10, 2020 •
edited by rileykarson
Loading

Release Note Template for Downstream PRs (will be copied)

storage: added `default_event_based_hold` to `google_storage_bucket`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 381a05c.

Pull request statuses

WARNING: The following files changed in commit 381a05c may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_storage_bucket.go

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1626
depends: GoogleCloudPlatform/terraform-google-conversion#319
depends: hashicorp/terraform-provider-google#5373
depends: ansible-collections/google.cloud#132
depends: modular-magician/inspec-gcp#300

rileykarson
rileykarson approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I'll get an approval on the InSpec downstream and merge.

@modular-magician modular-magician merged commit 0a5f54f into GoogleCloudPlatform:master Jan 16, 2020
@MartinNowak MartinNowak deleted the fix_terraform_4747 branch January 17, 2020 11:33
This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
@modular-magician modular-magician mentioned this pull request Mar 4, 2020
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@MartinNowak
add defaultEventBasedHold to storage buckets (GoogleCloudPlatform#2954)
fb18eaf 
Merged PR GoogleCloudPlatform#2954.
@mans0954 mans0954 mentioned this pull request Feb 7, 2022
Closed
melinath added a commit that referenced this pull request Feb 8, 2022
@melinath
Added description of default_event_based_hold
a8e8cfc 
Followup on #2954

Resolved hashicorp/terraform-provider-google#11044
@melinath melinath mentioned this pull request Feb 8, 2022
Merged
melinath added a commit that referenced this pull request Feb 8, 2022
@melinath
Added description of default_event_based_hold (#5694)
19e4053 
Followup on #2954

Resolved hashicorp/terraform-provider-google#11044
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Feb 8, 2022
@modular-magician
Added description of default_event_based_hold (hashicorp#5694)
e9b6f60 
Followup on GoogleCloudPlatform/magic-modules#2954

Resolved hashicorp#11044

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician mentioned this pull request Feb 8, 2022
Merged
modular-magician added a commit to hashicorp/terraform-provider-google that referenced this pull request Feb 8, 2022
@modular-magician
Added description of default_event_based_hold (#5694) (#11060)
5270214 
Followup on GoogleCloudPlatform/magic-modules#2954

Resolved #11044

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Feb 8, 2022
@modular-magician
Added description of default_event_based_hold (hashicorp#5694)
7fadd5e 
Followup on GoogleCloudPlatform/magic-modules#2954

Resolved hashicorp/terraform-provider-google#11044

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician mentioned this pull request Feb 8, 2022
Merged
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request Feb 8, 2022
@modular-magician
Added description of default_event_based_hold (#5694) (#4038)
80e0aa1 
Followup on GoogleCloudPlatform/magic-modules#2954

Resolved hashicorp/terraform-provider-google#11044

Signed-off-by: Modular Magician <[email protected]>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
@melinath @lcaggio
Added description of default_event_based_hold (GoogleCloudPlatform#5694)
c872c8a 
Followup on GoogleCloudPlatform#2954

Resolved hashicorp/terraform-provider-google#11044
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
@melinath @lcaggio
Added description of default_event_based_hold (GoogleCloudPlatform#5694)
c4c09bd 
Followup on GoogleCloudPlatform#2954

Resolved hashicorp/terraform-provider-google#11044
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
@melinath @betsy-lichtenberg
Added description of default_event_based_hold (GoogleCloudPlatform#5694)
a0bccd9 
Followup on GoogleCloudPlatform#2954

Resolved hashicorp/terraform-provider-google#11044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes community downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support enabling/disabling the event-based hold property on buckets
4 participants
@MartinNowak @modular-magician @rileykarson @googlebot