Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error if boot disk specified on non-first disk in instance template #2996

Merged

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Jan 21, 2020

Fixes: hashicorp/terraform-provider-google#5428

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_instance_template` add plan time check for any disks marked `boot` outside of the first disk

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 49242c0.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1662
depends: hashicorp/terraform-provider-google#5455

@slevenick
Copy link
Contributor Author

I think this is not worth a release note?

@danawillow
Copy link
Contributor

Could we do this as a plan-time check instead of apply-time?

And eh it's a user-visible change so I'd probably give it a bugfix release note.

@slevenick
Copy link
Contributor Author

@danawillow Moved check to plan time

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff
Terraform Beta: Diff

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff
Terraform Beta: Diff

@slevenick slevenick merged commit ae8195e into GoogleCloudPlatform:master Jan 24, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…te (GoogleCloudPlatform#2996)

* Add error if boot disk specified on non-first disk in instance template

* Move error to plan time rather than apply time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boot to set true for non-boot disks
4 participants