Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bigquery_options to be O+C #3035

Merged
merged 1 commit into from
Jan 29, 2020
Merged

update bigquery_options to be O+C #3035

merged 1 commit into from
Jan 29, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jan 29, 2020

Fixes hashicorp/terraform-provider-google#5501

Release Note Template for Downstream PRs (will be copied)

logging: updated `bigquery_options` so the default value from the api will be set in state.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff
Terraform Beta: Diff

@megan07 megan07 requested a review from chrisst January 29, 2020 17:54
@megan07 megan07 merged commit 7711aa0 into GoogleCloudPlatform:master Jan 29, 2020
This was referenced Jan 29, 2020
Closed
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@megan07
update bigquery_options to be O+C (GoogleCloudPlatform#3035)
86c47f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix _updateBigquerySink tests
4 participants
@megan07 @modular-magician @chrisst @googlebot