handle case where bigtable development instances have one node #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
approved these changes
Jan 31, 2020
|
Good idea, done. |
This was referenced Jan 31, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API still doesn't permit setting the node count for development instances, but if we send it as empty it might return 0 or 1 back. Unfortunately, customizediff can't tell that the field isn't set in the config if it is set in state (regardless of whether it's set to computed), so we have to have it allow 1 as a value for num_nodes even though it'll fail at apply-time.
Fixes hashicorp/terraform-provider-google#5492.
Release Note Template for Downstream PRs (will be copied)