-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decoder after OperationWaitTimeWithResponse #3146
Merged
emilymye
merged 1 commit into
GoogleCloudPlatform:master
from
emilymye:accesscontexttests
Feb 19, 2020
Merged
Add decoder after OperationWaitTimeWithResponse #3146
emilymye
merged 1 commit into
GoogleCloudPlatform:master
from
emilymye:accesscontexttests
Feb 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilymye
force-pushed
the
accesscontexttests
branch
from
February 18, 2020 23:42
7ccf773
to
df47792
Compare
emilymye
changed the title
move nested query into Decoder, add decoder after Operation w Response
Add decoder after OperationWaitTimeWithResponse
Feb 18, 2020
Looks like the Spanner decoder might not be necessary after this change? I'll test that in a different PR |
danawillow
reviewed
Feb 19, 2020
emilymye
requested review from
danawillow
and removed request for
nat-henderson and
danawillow
February 19, 2020 00:32
emilymye
force-pushed
the
accesscontexttests
branch
from
February 19, 2020 00:52
df47792
to
9d91abf
Compare
danawillow
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests for changed resources are passing
This was referenced Feb 19, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3085 hasn't been added to a release yet, I'm going to exclude the release note, but this should fix an issue with post-create read of AccessContextManager service perimeter resource
(fixes hashicorp/terraform-provider-google#5704)
Release Note Template for Downstream PRs (will be copied)