Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoder after OperationWaitTimeWithResponse #3146

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Feb 18, 2020

Since #3085 hasn't been added to a release yet, I'm going to exclude the release note, but this should fix an issue with post-create read of AccessContextManager service perimeter resource

(fixes hashicorp/terraform-provider-google#5704)

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 210 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 40 files changed, 234 insertions(+), 68 deletions(-))

@emilymye emilymye changed the title move nested query into Decoder, add decoder after Operation w Response Add decoder after OperationWaitTimeWithResponse Feb 18, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 47 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 17 files changed, 61 insertions(+), 17 deletions(-))

@emilymye
Copy link
Contributor Author

Looks like the Spanner decoder might not be necessary after this change? I'll test that in a different PR

@emilymye emilymye requested review from danawillow and removed request for nat-henderson and danawillow February 19, 2020 00:32
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 92 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 17 files changed, 111 insertions(+), 58 deletions(-))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests for changed resources are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccAccessContextManager
4 participants