Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move drain_nat_ips to GA from beta. #3209

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Move drain_nat_ips to GA from beta. #3209

merged 1 commit into from
Mar 4, 2020

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Mar 4, 2020 •
edited
Loading

Fixes hashicorp/terraform-provider-google#5566.

Release Note Template for Downstream PRs (will be copied)

compute: moved `google_compute_router_nat`'s `drain_nat_ips` from beta to ga.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 55 insertions(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@nat-henderson nat-henderson merged commit bb7197a into GoogleCloudPlatform:master Mar 4, 2020
This was referenced Mar 4, 2020
Merged
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@nat-henderson
Move drain_nat_ips to GA from beta. (GoogleCloudPlatform#3209)
6a3b5c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2thorn c2thorn c2thorn approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_compute_router_nat.drain_nat_ips beta -> GA
4 participants
@nat-henderson @modular-magician @c2thorn @googlebot