Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty vs null list in data source tests #3245

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Ignore empty vs null list in data source tests #3245

merged 1 commit into from
Mar 11, 2020

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Mar 11, 2020

Since null and empty lists are equivalent when translated through the sdk it
doesn't make sense to fail on this.

Release Note Template for Downstream PRs (will be copied)

test fix

@chrisst
Ignore empty vs null list in data source tests
bec3e21 
Since null and empty lists are equivalent when translated through the sdk it
doesn't make sense to fail on this.
@chrisst chrisst requested a review from c2thorn March 11, 2020 18:43
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@chrisst chrisst merged commit 65fc126 into GoogleCloudPlatform:master Mar 11, 2020
@chrisst chrisst deleted the sensitive-datasource-tests branch March 11, 2020 19:08
This was referenced Mar 11, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@chrisst
Ignore empty vs null list in data source tests (GoogleCloudPlatform#3245
6262a09 
)

Since null and empty lists are equivalent when translated through the sdk it
doesn't make sense to fail on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2thorn c2thorn c2thorn approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisst @modular-magician @c2thorn @googlebot