Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream] Add support for providing additional experiments to Dataflow job #3429

Merged

Conversation

danawillow
Copy link
Contributor

Upstreams hashicorp/terraform-provider-google#6196

Release Note Template for Downstream PRs (will be copied)

* added `additional_experiments` field to `google_dataflow_job`

Add support for providing additional experiments to Dataflow job

Fix formatting

Updating additional_experiements type to Set. Updating test case with another experiment

copy/paste changes
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 102 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 102 insertions(+), 10 deletions(-))

@danawillow danawillow requested a review from c2thorn April 27, 2020 20:15
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants