Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry on cloud functions error when pulling source from GCS #3570

Merged
merged 2 commits into from
May 27, 2020

Conversation

emilymye
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

functions: Added retry to `google_cloudfunctions_function` creation when API returns error while pulling source from GCS

Fixes hashicorp/terraform-provider-google#6132

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 19 insertions(+), 1 deletion(-))

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than whatever formatting issue, LGTM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 19 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Function deployment is Flaky: Error code 3, message: Failed to retrieve function source code
4 participants