Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tiers and nfs_export_options #3766

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 21, 2020

Fixes hashicorp/terraform-provider-google#6572

Release Note Template for Downstream PRs (will be copied)

filestore: added support for filestore high scale tier.
filestore: added `nfs_export_options` field on `google_filestore_instance.file_shares`. (beta-only)

@google-cla google-cla bot added the cla: yes label Jul 21, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 103 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 352 insertions(+), 8 deletions(-))
Ansible: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 130 insertions(+))
Inspec: Diff ( 6 files changed, 99 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134592"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134595"

- !ruby/object:Api::Type::Array
name: 'ipRanges'
description: |
List of either an IPv4 addresses in the format {octet 1}.{octet 2}.{octet 3}.{octet 4} or CIDR ranges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be copy-pasted but it's a little overly formal to me - I'd say "xxx.xxx.xxx.xxx or xxx.xxx.xxx.xxx/yy", or "an IPv4 address, or range in CIDR notation".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but feel free to submit without addressing - or after addressing without another review - totally at your discretion.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 44 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 344 insertions(+), 8 deletions(-))
Ansible: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 130 insertions(+))
Inspec: Diff ( 6 files changed, 99 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134818"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccEndpointsService_basic|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134819"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Filestore High Scale
3 participants