Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trust to ad domain 5731 #3798

Merged

Conversation

venkykuberan
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

AD Domain - added new resource `google_active_directory_domain_trust` 

@google-cla google-cla bot added the cla: yes label Jul 30, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 859 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 859 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 133 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136739"

@venkykuberan venkykuberan removed the request for review from nat-henderson July 30, 2020 16:33
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@megan07 megan07 removed the request for review from c2thorn July 30, 2020 20:49
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 875 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))
TF OiCS: Diff ( 4 files changed, 109 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136976"

@venkykuberan venkykuberan removed the request for review from rileykarson July 31, 2020 16:44
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 813 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 813 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137499"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137500"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 813 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 813 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137634"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccEndpointsService_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137635"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 836 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 836 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138131"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 815 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 815 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138134"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_basic|TestAccContainerCluster_misc|TestAccContainerCluster_withAddons|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_network|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_basic|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_resize|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_shieldedInstanceConfig|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138146"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 817 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 7 files changed, 817 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 117 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140456"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceDNSKeys_basic|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComposerEnvironment_update|TestAccComputeHealthCheck_healthCheckGrpcExample|TestAccComputeHealthCheck_healthCheckGrpcFullExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140458"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants