-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project overrides to gke services #3892
Add project overrides to gke services #3892
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141433" |
third_party/terraform/resources/resource_container_node_pool.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_container_node_pool.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_container_node_pool.go.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141441" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComputeInstanceFromTemplate_basic|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141444" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141463" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComputeInstanceFromTemplate_basic|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141466" |
third_party/terraform/tests/resource_google_project_service_test.go
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_container_node_pool.go.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142280" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142283" |
FYI this changelog note did not pass the changelog generator. I'm not sure whether the issue is the extra empty lines or having two messages in one changelog note, but just an FYI. |
(and by that I mean, it won't pass the changelog generator next week, which is when this will actually appear. I messed up the command this week but fixed it now) |
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Fixes : hashicorp/terraform-provider-google#6914