Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project overrides to gke services #3892

Conversation

venkykuberan
Copy link
Contributor

@venkykuberan venkykuberan commented Aug 21, 2020

If this PR is for Terraform, I acknowledge that I have:

  • [X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


container  : added project override support to `google_container_cluster` and `google_container_nodepool`
servicemanagement : added project override support to `google_project_service`

Fixes : hashicorp/terraform-provider-google#6914

@google-cla google-cla bot added the cla: yes label Aug 21, 2020
@venkykuberan venkykuberan requested review from danawillow and rileykarson and removed request for danawillow August 21, 2020 16:38
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 222 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 6 files changed, 258 insertions(+), 57 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141433"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 222 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 6 files changed, 258 insertions(+), 57 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141441"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComputeInstanceFromTemplate_basic|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141444"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 199 insertions(+), 49 deletions(-))
Terraform Beta: Diff ( 6 files changed, 235 insertions(+), 59 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141463"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComputeInstanceFromTemplate_basic|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=141466"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 195 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 6 files changed, 231 insertions(+), 60 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142280"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142283"

@danawillow
Copy link
Contributor

FYI this changelog note did not pass the changelog generator. I'm not sure whether the issue is the extra empty lines or having two messages in one changelog note, but just an FYI.

@danawillow
Copy link
Contributor

(and by that I mean, it won't pass the changelog generator next week, which is when this will actually appear. I messed up the command this week but fixed it now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user project overrides to GKE and service usage resources
4 participants