Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct data type for Notebook Instance Owners field, add some enums #3912

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Conversation

gogasca
Copy link
Contributor

@gogasca gogasca commented Aug 26, 2020

Add Initialization state
Getting: Error:

Error reading Instance: instance_owners: '' expected type 'string', got unconvertible type '[]interface {}'

Currently Instance owners is type Array with string items
https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances#Instance

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

notebooks: fixed broken `google_notebooks_instance.instance_owners` field by making it a list instead of a string
notebooks: added `PD_BALANCED` as a possible disk type for `google_notebooks_instance`

Add Initialization state
Getting: Error: Error reading Instance: instance_owners: '' expected type 'string', got unconvertible type '[]interface {}'
Currently Instance owners is type Array with string items
https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances#Instance
@google-cla google-cla bot added the cla: yes label Aug 26, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142511"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142527"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccComposerEnvironment_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142528"

products/notebooks/api.yaml Outdated Show resolved Hide resolved
products/notebooks/api.yaml Show resolved Hide resolved
products/notebooks/api.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142784"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142798"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I updated the changelog note a bit, you can take a look if you're curious.

@danawillow danawillow changed the title Update api.yaml add Initialization state, correct Instance Owners field Correct data type for Notebook Instance Owners field, add some enums Aug 27, 2020
@danawillow danawillow merged commit b2de046 into GoogleCloudPlatform:master Aug 27, 2020
@gogasca
Copy link
Contributor Author

gogasca commented Aug 27, 2020

Thanks Dana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants