-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct data type for Notebook Instance Owners field, add some enums #3912
Conversation
Add Initialization state Getting: Error: Error reading Instance: instance_owners: '' expected type 'string', got unconvertible type '[]interface {}' Currently Instance owners is type Array with string items https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances#Instance
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142511" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142527" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccComposerEnvironment_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142528" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 9 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142784" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142798" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I updated the changelog note a bit, you can take a look if you're curious.
Thanks Dana! |
Add Initialization state
Getting: Error:
Currently Instance owners is type Array with string items
https://cloud.google.com/ai-platform/notebooks/docs/reference/rest/v1beta1/projects.locations.instances#Instance
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)