Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema update support to spanner db 2082 #3947

Conversation

venkykuberan
Copy link
Contributor

@venkykuberan venkykuberan commented Sep 3, 2020

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: Added schema update/update ddl support for `google_spanner_database`

fixes: hashicorp/terraform-provider-google#2082

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144398"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144398"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144400"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144400"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 169 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 169 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144603"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccIapWebBackendServiceIamBindingGenerated_withCondition|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccIapWebBackendServiceIamMemberGenerated_withCondition|TestAccIapWebBackendServiceIamPolicyGenerated_withCondition|TestAccProviderBasePath_setBasePath|TestAccComposerEnvironment_update|TestAccComposerEnvironment_private|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withWebServerConfig|TestAccComputeDisk_VSSWindows|TestAccComputeHttpHealthCheck_update|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_stateful|TestAccDataprocCluster_withInternalIpOnlyTrue|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_privateUpdate|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccDNSManagedZone_reverseLookup|TestAccDNSPolicy_update|TestAccDNSRecordSet_basic|TestAccDNSRecordSet_modify|TestAccDNSRecordSet_changeType|TestAccDNSRecordSet_ns|TestAccDNSRecordSet_nestedNS|TestAccDNSRecordSet_quotedTXT|TestAccDNSRecordSet_uppercaseMX|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccProject_deleteDefaultNetwork|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSecurityScannerScanConfig_scanConfigBasicExample|TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update|TestAccSpannerDatabase_basic|TestAccSqlDatabaseInstance_withPrivateNetwork You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144607"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 204 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 204 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145183"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 204 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 204 insertions(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145186"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDisk_VSSWindows|TestAccComputeSnapshot_encryptionCMEK|TestAccSpannerDatabase_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145188"

@danawillow
Copy link
Contributor

For the test failure, it looks like the Spanner API returns success on DELETE before the database is finished deleting, and doesn't supply an operation to wait on. It's probably best to just remove the ForceNew test, since there's not much we can really do to fix it and we don't typically test ForceNew scenarios.

@danawillow
Copy link
Contributor

Never mind! I just looked at it again and it's actually an error I'm familiar with. I don't have a solution, but if retrying the test fixes it then you could leave it in.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 329 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 329 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146306"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 318 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 318 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146388"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 248 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 248 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146423"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 248 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 248 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146561"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccSpannerDatabase_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146591"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good, thanks for putting in the extra effort! Right now the test is failing but I've left a comment that should fix it. If that does the trick, feel free to merge.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 254 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 254 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146600"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 254 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 254 insertions(+), 4 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146604"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 269 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 5 files changed, 269 insertions(+), 19 deletions(-))
Ansible: Diff ( 1 file changed, 17 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 35 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146614"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeSnapshot_encryptionCMEK|TestAccContainerCluster_withAddons|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update|TestAccSpannerDatabase_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=146626"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Spanner DB schema migrations
3 participants