-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add access_context_manager_access_level_condition #4074
add access_context_manager_access_level_condition #4074
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151245" |
36960b1
to
c320040
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151742" |
c320040
to
b883116
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151758" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccProviderMeta_setModuleName|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccAccessContextManager|TestAccSQLDatabase_sqlDatabaseBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151770" |
insert_minutes: 4 | ||
autogen_async: true | ||
exclude_validator: true | ||
exclude_import: true # no unique way to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there no unique way to specify? Is the collection of identity fields not sufficient to identify a condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have done this wrong, but I made the collection of identity fields all the fields, because that's the only way to find it's truly unique. Does that make sense?
third_party/terraform/tests/resource_access_context_manager_access_level_condition_test.go
Show resolved
Hide resolved
resource "google_access_context_manager_access_policy" "access-policy" { | ||
parent = "organizations/123456789" | ||
title = "my policy" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline here to fit with other files
|
||
resource "google_service_account" "created-later" { | ||
account_id = "%s" | ||
depends_on = [google_access_context_manager_access_level.test-access] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be created afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it doesn't really have to - I'm trying to emulate the situation that the user creates the access level, then later creates a service account and wants to add that to the list of members in the access level's condition, which was the premise of the issue. For testing purposes it probably doesn't matter, I can take that out.
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151958" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151961" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151964" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151965" |
Add
access_context_manager_access_level_condition
Fixes hashicorp/terraform-provider-google#6512
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)