-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update network peering custom routes #4138
Conversation
Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: angie pinilla <[email protected]>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
This is in the |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153624" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccComputeNetworkPeering_customRoutesUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153643" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but maybe a couple of those fields should still be ForceNew? Can we actually update any field other than the network field?
Fixes: hashicorp/terraform-provider-google#5971
Upstreams/Updates: hashicorp/terraform-provider-google#6020
Updated the original PR to be consistent with general changes made to the providers since the PR was pushed. Added a few other fixes to both the update logic and tests.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)