Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "GA for gVNIC support (#4511)" #4519

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 22, 2021

This reverts commit d63a4a8.

#4511 works fine for Compute Instances, but there is issues with Instance Templates. Reverting for now.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Feb 22, 2021
@c2thorn
Copy link
Member Author

c2thorn commented Feb 22, 2021

Closing, I see #4516 is pending

@c2thorn c2thorn closed this Feb 22, 2021
@c2thorn c2thorn reopened this Feb 22, 2021
@c2thorn
Copy link
Member Author

c2thorn commented Feb 22, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 1 insertion(+), 101 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1 insertion(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173789"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 1 insertion(+), 101 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1 insertion(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173790"

Copy link
Contributor

@edwardmedia edwardmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants